Bug overview description.

I added the following sources to post #2181652:

https://www.pixiv.net/en/artworks/80169645
https://www.pixiv.net/en/users/160919
https://i.pximg.net/img-original/img/2020/03/17/00/36/41/80169645_p0.jpg

The following source was automatically added:

https://www.pixiv.net/member_illust.php?mode=medium&illust_id=80169645

The added source resolves to the same Pixiv post URL (https://www.pixiv.net/en/artworks/80169645) and cannot be manually removed.

What part(s) of the site page(s) are affected?

Posts.

What is the expected behavior?

The expected behavior is to prevent automatically adding Pixiv post URLs when a resolved version is already present in the source field.

What actual behavior is given instead?

See bug overview.

Time of incident (if applicable).

~4:52 PM EST, June 30, 2020

Can you reproduce the bug every time?

The bug can be reproduced every time. post #1794553 also displayed the behavior. The automatically added URL cannot be removed in subsequent post updates.

What steps did you take to replicate this bug?

See bug overview.

Errors or other messages returned (if any).

N/A

That's a legacy url (which works fine). (ps: https://e621.net/forum_posts/287521)

aobird said:
That's a legacy url (which works fine). (ps: https://e621.net/forum_posts/287521)

Yeah, but similar to other sites like twitter media links and inkbunny submission pages, it would be ideal to use the new formatting all across the board for consistancy and in case legacy formats stop working at some point.
Which is kinda hard when site enforces old format.

mairo said:
Yeah, but similar to other sites like twitter media links and inkbunny submission pages, it would be ideal to use the new formatting all across the board for consistancy and in case legacy formats stop working at some point.
Which is kinda hard when site enforces old format.

Pixiv forces new, not old. Twitter api uses old url though.

aobird said:
Pixiv forces new, not old. Twitter api uses old url though.

I believe Mairo was referring to e621 with "site". e621 code adds the old Pixiv post URL instead of the new one if a direct image link was added, which results in URLs being functionally duplicated in the source field.

songbird said:
I believe Mairo was referring to e621 with "site". e621 code adds the old Pixiv post URL instead of the new one if a direct image link was added, which results in URLs being functionally duplicated in the source field.

Mhmm.

I've updated the template and will see if I can make it remove the older urls if there are duplicates present. It should also now recognize and be able to recognize the new url format. Normally the system is only set up to add missing urls and not remove old ones, but it seems like a needed feature now.

I will deploy a copy of this change when it is ready.

EDIT: Deployed site wide.