Requested feature overview description.

On the notes search page, add a field for post ID. On the notes versions page, add the same search form that already appears on the notes page.

Why would it be useful?

Firstly, why the hell is this not already a thing?

Anyway, one case which keeps coming up every time I delve into the ambiguous character tags is those wall-of-characters posts that a bunch of people thought would be hilarious to upload circa 10 years ago. Sometimes I get lucky and some (or many) kind soul has marked out every character with notes.

Today it was post #248416. I wanted to know why the fiona tag was on that image, so I clicked on the notes history to get a link that would highlight whichever note said "Fiona". There are eight pages of notes history. Do I want to do the Ctrl-F/click next shuffle yet again? No, but there is seemingly no search available on the current page, so I copy the post ID and then click the "Search" link at the top. Inexplicably, this only offers three possible fields to search by: "Body", "Author" and "Tags". Despite the fact I was literally just looking at a list of notes filtered by post ID.

After comparing the format of the two URLs, I determined that both of the following manually crafted links work as expected:

https://e621.net/notes?commit=Search&search[body_matches]=Fiona&search[post_id]=248416

https://e621.net/note_versions?search[post_id]=248416&search[body_matches]=Fiona

So it's literally just a user interface side problem. Add an extra field to the search form and everyone's happy. The same search form should also appear in the same place when looking at the list of versions, with post ID automatically filled in if you clicked the history link from a post page, exactly the same as tags history already works.

I will emphasise again that all of this is already fully implemented - it just needs to be exposed.

It was princess_fiona, BTW, and yes of course that tag was already on the same post. These days I say "fuck klorpa " like a Catholic makes the sign of the cross.

What part(s) of the site page(s) are affected?

Notes search, notes history

Absolutely, I'll make a PR for this in a bit.

Edit: actually going to add a few more things - there's a lot of permitted parameters that aren't accessible from the UI.

Edit 2: PR #469

faucet said:
Absolutely, I'll make a PR for this in a bit.

Edit: actually going to add a few more things - there's a lot of permitted parameters that aren't accessible from the UI.

Edit 2: PR #469

Wow, thanks for doing that (especially with such a quick turnaround). If I may make one suggestion, do the "Author" and "User" fields mean the same thing? If so, they should probably be named consistently. I think we generally prefer "User" in search forms.

wat8548 said:
If I may make one suggestion, do the "Author" and "User" fields mean the same thing? If so, they should probably be named consistently. I think we generally prefer "User" in search forms.

I wouldn't object to making it say "User" in both cases, "Author" was already there on that page so I didn't touch it. I used "User" on the notes versions page because author didn't seem to fit when it's only an edit, and it matched post changes.

Since I have plenty of time to waste. Looking at a bunch of other pages...

• Aliases/Implications/BURs: Creator and Approver
• Approvals: Approver
• Artist history: User
• Artists: Creator
• Bans: User and Banner
• Blips: Blipper
• Comments: Commenter
• Forum: Author
• Pool history: No search.
• Pools: Creator
• Post changes: User
• Replacements: Creator, Approver and Original Uploader
• Sets: Username
• Tag type history: Username
• Users: Name
• Wiki page versions: No search.
• Wiki: Creator name

...it seems like there's very little consistency on the site in general, even more so when it comes to the table headings, but it does seem to more often describe the user's role in the data rather than simply just call them a user. (Obviously excepting the pages that have multiple user-related search boxes, it would be crazy to have 3 of those labelled simply "User"). I feel like "Creator" might be a better word than "Author" on the notes page, but not really sure about the updates page. I don't think "updater" is generally an accepted word in that context? Editor could be a possibility.