Topic: Quick question

Posted under General

Rainbow Dash

Admin

I feel like maybe 1/10 or so. That might not seem like a lot, but it's more than I want

TheGreatWolfgang

Privileged

rainbow_dash said:
I feel like maybe 1/10 or so. That might not seem like a lot, but it's more than I want

Has anybody gotten slapped for repeatedly using the Report button to reply to comments (even after getting told not to)?

Maryland P Sevenson

Member

demesejha said:
Im not really sure it matches the site design?? Its def good but i dont think it fits this site. It feels too social media/bbs

I mean, it dosn't look too dissimilar to how comments on IB and FA look, and dealing mobile, minimizing the amount of real estate that gets wasted is kind of an big deal.

Cinder

Admin

demesejha said:
Im not really sure it matches the site design?? Its def good but i dont think it fits this site. It feels too social media/bbs

E621's design is positively ancient.
You can take the Wayback Machine back to 2013, and see how little the site changed in terms of visuals. Some elements are way older than that.
I'm not gonna say that it's a bad thing – it's very functional. I just think that it's also pretty ugly in some places – including both the comment section and the forums.

What you are referring to as "social media" is simply more modern design paradigms.
In this case, I was mostly inspired by Github's comment design – you can see in the pull request itself how similar the two are.

I think that we should stop clinging to old design decisions just because they are familiar, and try something new.
After all, I don't think I've seen anyone complain about the design of the DText preview window / formatting buttons. And that one is also inspired by Github.

dba_afish said:
hmm... yeah, that dosn't look half bad, unfortunate that it went unimplemented.

It was fully implemented – that is, the code for it was written, and still exists.
It just never got reviewed, much like my blacklist redesign, Donovan's rework of the DNP system, or Catt0s' replacements list redesign.
Or dozens of other pull requests: https://github.com/e621ng/e621ng/pulls

Maryland P Sevenson

Member

cinder said:
After all, I don't think I've seen anyone complain about the design of the DText preview window / formatting buttons. And that one is also inspired by Github.

honestly, those formatting buttons could probably be better. the first four are fine, but the other half are odd. [spoiler] I kinda get, it's commonly used enough, [qoute] and [code] seem a bit situational to put up there, and literally no one uses h2., I mean, it's so rarely used that it's had the wrong formatting since the move to ng and no one even noticed.

Updated

bitWolfy

Former Staff

dba_afish said:
honestly, those formatting buttons could probably be better. the first four are fine, but the other half are odd. [spoiler] I kinda get, it's commonly used enough, [qoute] and [code] seem a bit situational to put up there, and literally no one uses h2., I mean, it's so rarely used that it's had the wrong formatting since the move to ng and no one even noticed.

I initially made the formatting buttons thing for my userscript re621. In re6, those buttons are customizable, you can put up pretty much anything you want in there.
When I adapted it for vanilla e6, I simplified it right down – the buttons are now pre-set. I barely use the DText markup myself, so I just put one of everything on there.

Not sure what you mean about the h2, though.

Seems to work just fine

Maryland P Sevenson

Member

bitwolfy said:
Not sure what you mean about the h2, though.

Seems to work just fine

oh, it must be a mobile thing then. on mobile h2. is considerably smaller than all of the other headers and also smaller than normal text. (it's .825em when h6. and normal text is 1em).

I'm guessing its because <h2> is the element used for a bunch of the buttons across the site and whoever made the mobile UI never realized that the .styled-dtext h2 gets overwritten by body.resp h2 when it probably shouldn't.

bitWolfy

Former Staff

dba_afish said:
oh, it must be a mobile thing then. on mobile h2. is considerably smaller than all of the other headers and also smaller than normal text. (it's .825em when h6. and normal text is 1em).

I'm guessing its because <h2> is the element used for a bunch of the buttons across the site and whoever made the mobile UI never realized that the .styled-dtext h2 gets overwritten by body.resp h2 when it probably shouldn't.

Huh, so it is. How strange.
https://github.com/e621ng/e621ng/blame/master/app/javascript/src/styles/common/z_responsive.scss#L319-L322

SNPtheCat

Member

cinder said:
E621's design is positively ancient.

After all, I don't think I've seen anyone complain about the design of the DText preview window / formatting buttons. And that one is also inspired by Github.

Well I guess I can be the second. With mobile mode support enabled, the button for h2. is cut in half and the buttons off to its right are inaccessible, which i'm not particularly a fan of.

Maryland P Sevenson

Member

snpthecat said:

Well I guess I can be the second. With mobile mode support enabled, the button for h2. is cut in half and the buttons off to its right are inaccessible, which i'm not particularly a fan of.

on mine the [code] and [quote] buttons are offscreen. and when editing the spoiler button is bisected by the end of the box.

Cinder

Admin

snpthecat said:

Well I guess I can be the second. With mobile mode support enabled, the button for h2. is cut in half and the buttons off to its right are inaccessible, which i'm not particularly a fan of.

I obviously meant "nobody complained about its existence or claimed that it does not fit the site's design", not "nobody reported any bugs in its implementation".
Don't be deliberately dense.

Calydor

Member

cinder said:
I obviously meant "nobody complained about its existence or claimed that it does not fit the site's design", not "nobody reported any bugs in its implementation".
Don't be deliberately dense.

Gee, I wonder why people don't say anything ...

  • 1