Bug overview description.
Just noticed that post uploaded from DA had source link which gave 404 on me. I replaced the source link with correct one, but site automatically inserted the false source back in.

post #990012

What part(s) of the site page(s) are affected?
Posts directly uploaded from DA and artists page url containing "-" character in name.

What is the expected behavior?
Insertion of correct source and/or not adding incorrect source back in after editing.

What actual behavior is given instead?
Source is being put and replaced with incorrect one.

Time of incident (if applicable).
Withing last hour, posting and editing sources of post #990012

Can you reproduce the bug every time?
Haven't tested it with upload again as I can't post unrelated content just to test this.
Though I am still unable to remove false source.

What steps did you take to replicate this bug?
None. But would've taken DA artist with "-" in name and used direct uploading without providing any sources in source box.

Errors or other messages returned (if any).
None.

Bug confirmed, but not sure if I actually want to "fix" it or not.

This is part of the automatic source detection routine, and in any case other than this one, it gets things right. The reason it is pulling in the one with underscores is because DeviantArt does weird things with their urls. It is detecting https://orig04.deviantart.net/2a03/f/2012/040/9/b/arctic_lord_by_tojo_the_thief-d4p5t7j.png and finding the "by_tojo_the_thief-" and using that to create an automatic link back to the artist profile. Since DeviantArt converted the hyphens to underscores, it thinks that the username has underscores. Unless I can confirm that DeviantArt usernames cannot contain underscores, this is am ambiguity that isn't well resolved.

I'm open to suggestions on a better pattern or resolution step if anyone has some ideas to throw around. I believe that the automatic detection and adding of the source has enough value that removing it outright would be a mistake.

Trying to register nickname on DA with underscores brings up "Check your username has only letters, numbers and hyphens"
So, asd_asd is illegal, but asd-asd can be used if it wasn't taken already. Meaning it's highly unlikely that there's nicknames with underscore.

If this wasn't the case, I would still suggest that allowing of manual removal after the upload would've been necessary.

Also it seems like the image url is done with
"image_name_by_artist-dstring.filetype"
which can be linked to original submission page by inserting the info into following
"https://`artist`.deviantart.com/gallery/#/d`string`"
which then redirects to submission page.

And on a related note, feel like https should be standard when automatically inserting source links.