Bug overview description.
Hitting enter key of keyboard while editing tags submits post early
What part(s) of the site page(s) are affected?
All posts everywhere
What is the expected behavior?
Hitting enter will create a new line instead of submitting the edit
What actual behavior is given instead?
Hitting enter submits edit request, submitting all changes
Time of incident (if applicable).
N/A
Can you reproduce the bug every time?
100% consistency
What steps did you take to replicate this bug?
Go to a post, select the tag text box, press enter
Note:
More of a user interface design error. Editing tags while uploading creates a new line. Editing tags while editing an uploaded post submits the edit request. This inconsistency has led me to make many redundant edits when I could have changed a lot of tags in one. Would recommend changing the functionality of either the edit page or the upload page.

I can't find the thead right now, but if I can recall correctly the inconsistency was intentional.

This is currently by design. Having enter key submit the edits makes tag editing a lot faster for experienced taggers.

But the inconsistency between editing tags during upload, and editing tags on posts, is a problem. I'm not sure what would be the best way to fix it, while keeping a "single-key save changes" feature.

This is intentional, since most people want to quickly add a few tags and then slam the Enter key, which speeds up the process a bit more than it would when you have to reach for your mouse every time.

The upload page actually used to function the same until half a year ago, but that was obviously causing lots of more harmful slip-ups where someone would accidentally hit Enter and upload an image with incomplete tags, followed by panicked edits.

That sucked. Having to repeatedly press Shift plus Hyphen/Minus for all the damn underscores without once grazing Enter (conveniently placed right above Rshift on most keyboards) sucked dick, so I'm very very glad that's been changed. Makes life so much easier for frequent uploaders.

For regular edits to an existing post however, prematurely submitting is at worst a minor annoyance, you can just edit again and nobody will be any the wiser. ...Unless they check the tag history, but who cares that someone made a bunch of brief edits instead of one large? _{God knows I'm guilty of that alllll the time ;-;}

I do agree that the inconsistency can be tricky to new users, though. And to be honest, the whole 'reaching for your mouse' thing? Well, that's what you'd normally do after an edit anyway because you're probably going to want to click something, even just to navigate, so in practice it wouldn't really make a difference if you'd have to do it before submitting your edit instead of after.

Yeah, I wouldn't be opposed to equalizing the two.

Delian said:
This is currently by design. Having enter key submit the edits makes tag editing a lot faster for experienced taggers.

But the inconsistency between editing tags during upload, and editing tags on posts, is a problem. I'm not sure what would be the best way to fix it, while keeping a "single-key save changes" feature.

Can we do ctrl+enter submits a post?

fewrahuxo said:
Can we do ctrl+enter submits a post?

Huh. Ya, that could be a decent idea too, letting people keep the option of using their keys without having it be as prone to unintended activation.

This is not a UI bug IMO. the lack of it would be a UI bug. Enter to submit forms or confirm dialogs is fairly standard.

Also if we change this to Ctrl+Enter, we would either: a) create an additional inconsistency, where the 'edit' mode works with Enter but the /post/12345 tag editing requires Ctrl+Enter, or b) require 'edit' mode tag editing to use Ctrl+Enter.

If anything, what about: Ctrl+Enter creates a newline. That can be done everywhere without disruption, and it reflects that newlines actually have no real impact on tagging.

savageorange said:
This is not a UI bug IMO. the lack of it would be a UI bug. Enter to submit forms or confirm dialogs is fairly standard.

Also if we change this to Ctrl+Enter, we would either: a) create an additional inconsistency, where the 'edit' mode works with Enter but the /post/12345 tag editing requires Ctrl+Enter, or b) require 'edit' mode tag editing to use Ctrl+Enter.

If anything, what about: Ctrl+Enter creates a newline. That can be done everywhere without disruption, and it reflects that newlines actually have no real impact on tagging.

Somebody could do the hard work of overhauling the tag edits to allow for newlines, solving the inconsistency. It's not hard to imagine pressing "enter" is a large task.

fewrahuxo said:
Somebody could do the hard work of overhauling the tag edits to allow for newlines, solving the inconsistency.

But they do allow for newlines IIRC -- try pasting some in.

What I was saying was just that newlines are meaningless -- they're equivalent to a space for the purposes of tag edits.
(ie. there is no reason that you would ever *need* to input them, from the system's point of view)

Certain types of word processors do the exact same thing (though I can't recall offhand whether it's Ctrl+Enter or Shift+Enter that is more commonly used to forcibly insert a newline.)

Anyway my argument is basically that newlines are irrelevant to this task, so they shouldn't be insertable with a single keypress.

It's not hard to imagine pressing "enter" is a large task.

I think you unintentionally reversed the meaning of that? Doesn't make sense to me, anyway.